Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump typescript from 5.2.2 to 5.6.2 #667

Merged
merged 8 commits into from
Oct 1, 2024
Merged

chore(deps): bump typescript from 5.2.2 to 5.6.2 #667

merged 8 commits into from
Oct 1, 2024

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Sep 20, 2024 •
edited
Loading

Component schema changes

Use Type.Composite instead of Type.Intersect so Typescript does not complain. Typewise equal since there the union type does not contain the base type.

TypeScript and Dependency Updates

This PR updates the TypeScript version from 5.2.2 to 5.6.2 across various package.json files in the project. Additionally, it includes the following changes:

  • Updates @types/node from ^20.14.5 to ^22.5.5 in relevant packages
  • Upgrades @sinclair/typebox from ^0.32.34 to ^0.33.12 in the components package
  • Refactors ESLint configurations to use the new flat config format
  • Adjusts some type definitions and utility functions for improved type safety
  • Updates the generated comment in the Prisma selectableTypes file
  • Removes unnecessary dependencies from useCallback hooks in the Storybook preview file

These updates aim to improve type checking, take advantage of new TypeScript features, and enhance overall code quality across the project.

@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:22am

@karrui Graphite App
Copy link
Contributor Author

karrui commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karrui and the rest of your teammates on Graphite Graphite

@karrui karrui changed the title feat: update typescript to 5.6.2 feat: upgrade TypeScript to version 5.6.2 Sep 20, 2024
@karrui karrui changed the title feat: upgrade TypeScript to version 5.6.2 chore(deps): bump typescript from 5.2.2 to 5.6.2 Sep 20, 2024
@karrui karrui marked this pull request as ready for review September 20, 2024 04:18
@karrui karrui requested a review from a team as a code owner September 20, 2024 04:18
@karrui karrui mentioned this pull request Sep 20, 2024
Closed
@karrui
Copy link
Contributor Author

karrui commented Sep 20, 2024

this update i think cursed @dcshzj hitting the limitations of typescript liow

@dcshzj
Copy link
Contributor

dcshzj commented Sep 20, 2024

this update i think cursed @dcshzj hitting the limitations of typescript liow

Yeah a bit cancer idk what happened here, did they adjust the limit or something?

@karrui
Copy link
Contributor Author

karrui commented Sep 20, 2024

this update i think cursed @dcshzj hitting the limitations of typescript liow

Yeah a bit cancer idk what happened here, did they adjust the limit or something?

I think so. or just more strict. should try to avoid it or later we stuck permanently on typescript v5.2 lol. hard limited by typebox 😆. At most write a script to add ts-ignore on the offending lines.

@karrui karrui marked this pull request as draft September 20, 2024 10:45
@karrui karrui force-pushed the 09-20-feat_update_typescript_to_5.6.2 branch from 3ddcafa to 27a744d Compare September 26, 2024 07:39
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Sep 26, 2024 •
edited
Loading

Datadog Report

Branch report: 09-20-feat_update_typescript_to_5.6.2
Commit report: 3d3078c
Test service: isomer-studio

✅ 0 Failed, 8 Passed, 1 Skipped, 0s Total Time

@karrui
feat: update eslint exports to use tseslint.config
037feb7
@karrui
fix: use Type.Composite instead of Type.Intersect to avoid ts2589
5b5c160 
The types do not actually need to be an intersection since the `version` key in BaseItemSchema is not present in any of the union types
@karrui karrui marked this pull request as ready for review September 26, 2024 08:26
@dcshzj
Copy link
Contributor

dcshzj commented Oct 1, 2024

@karrui can merge this now, the schema change is ok to make now

@karrui karrui merged commit c3cee0a into main Oct 1, 2024
22 checks passed
@karrui karrui deleted the 09-20-feat_update_typescript_to_5.6.2 branch October 1, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishv7 harishv7 harishv7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrui @dcshzj @harishv7